Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace removed std.Build.host with std.Build.graph.host #429

Closed
wants to merge 1 commit into from

Conversation

futsuuu
Copy link

@futsuuu futsuuu commented Dec 11, 2024

SSIA

@futsuuu futsuuu changed the title fix: replace deprecated std.Build.host with std.Build.graph.host fix: replace removed std.Build.host with std.Build.graph.host Jan 6, 2025
@futsuuu
Copy link
Author

futsuuu commented Jan 6, 2025

@andrewrk Would you please review?

@kristoff-it
Copy link
Member

The website shows snippets for the current stable release. Those snippets are tested by CI and will be updated once 0.14.0 is released.

@futsuuu
Copy link
Author

futsuuu commented Jan 23, 2025

@kristoff-it std.Build.host is already deprecated in Zig v0.13.0. ziglang/zig@22a97cd

@kristoff-it
Copy link
Member

kristoff-it commented Jan 30, 2025

My bad! This surprised me because I excpected to see a build error in case of a wrong snippet.

This means that we also need to fix something else on the CI machine.

Thanks for your report.

@kristoff-it kristoff-it reopened this Jan 30, 2025
@kristoff-it
Copy link
Member

I reviewed the build script. b.host still works in 0.13.0. once @deprecated is implemented and deprecation turns in a compile error, we'll start updating code snippets on the website more eagerly, but not for now.

The 0.14.0 release will update that stuff.

@futsuuu futsuuu deleted the fix/b-host branch February 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants