wasi: fix wasm-wasi-musl SYMLINK_{NO,}FOLLOW constants and enable tests #22684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
reviewed
Jan 31, 2025
rootbeer
force-pushed
the
wasi-constant-fix
branch
from
d6e17b9 to
d52d200
Compare
Zig's copy of the `SYMLINK_{NO,}FOLLOW` constants from wasi-musl was
wrong, as were the `IFIFO` and `IFSOCK` file type flags. Fix these up,
and add comments pointing to exactly where they come from (as the
wasi-musl source has lots of unused, different definitions of these
constants).
Add tests for the Zig convention that WASM preopen 3 is the current
working directory. This is true for WASM with or without libc.
Enable several fs and posix tests that are now passing (not necessarily
because of this change) on wasm targets.
Fixes ziglang#20890.
rootbeer
force-pushed
the
wasi-constant-fix
branch
from
d52d200 to
881067b
Compare
|
@squeek502 is this good to go in your view? |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zig's copy of the
SYMLINK_{NO,}FOLLOWconstants from wasi-musl was wrong, as were theIFIFOandIFSOCKfile type flags. Fix these up, and add comments pointing to exactly where they come from (as wasi-musl has lots of unused, different definitions of these constants).Add tests for the Zig convention that WASM preopen 3 is the current working directory. This is true for WASM with or without libc.
Enable several fs and posix tests that are now passing (not necessarily because of this change) on wasm targets.
Fixes #20890.