std.os.linux: use isize to more accurately reflect mmap offset semantics
#22782
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Feb 8, 2025
lib/std/os/linux.zig
Outdated
| @@ -916,7 +916,7 @@ pub fn mmap(address: ?[*]u8, length: usize, prot: usize, flags: MAP, fd: i32, of | |||
| prot, | |||
| @as(u32, @bitCast(flags)), | |||
| @bitCast(@as(isize, fd)), | |||
| @as(u64, @bitCast(offset)), | |||
| @truncate(@as(u64, @bitCast(offset))), | |||
There was a problem hiding this comment.
seems obviously wrong? you're going to truncate the offset and now it becomes an incorrect value?
There was a problem hiding this comment.
I see your point on a second glance!
garrisonhh
changed the title
mmap offset in all casesisize to more accurately reflect offset semantics
garrisonhh
changed the title
isize to more accurately reflect offset semanticsisize to more accurately reflect mmap offset semantics
garrisonhh
force-pushed
the
mmap-offset-type-error
branch
from
18bf783 to
b5bf482
Compare
andrewrk
requested changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22464.