Fix connectUnix and allow passing connections to fetch() #23948
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectUnix()
was broken by the changes to how we manage the connection pool that were made when length tracking was removed fromstd.DoublyLinkedList
. If a developer attempted to use it currently, it would fail to compile due to it relying on incorrect types.In addition, it was previously impossible to use the
client.fetch()
API to work with unix sockets. If a developer wanted to make a request on a socket, they were required to use the low-level request API viaclient.open()
. This lead to code like the following:If we allow developers to use the fetch API, the function body can be greatly simplified: