Backup/restore routing table and allow specifying TX power during formation #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddly
force-pushed
the
puddly/restore-routing-table
branch
from
28270d2 to
39a2c87
Compare
puddly
force-pushed
the
puddly/restore-routing-table
branch
from
39a2c87 to
55d537b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #690 +/- ##
=======================================
Coverage 99.54% 99.55%
=======================================
Files 58 58
Lines 3975 4039 +64
=======================================
+ Hits 3957 4021 +64
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| channel=t.uint8_t(25), | ||
| channel_mask=t.Channels.ALL_CHANNELS, | ||
| security_level=t.uint8_t(1), | ||
| tx_power=0, |
There was a problem hiding this comment.
For the zigpy_backup fixture:
Shouldn't matter for the test, but was this intentionally set to 0, instead of e.g. 8?
There was a problem hiding this comment.
I think I set it to 0 to implicitly test if tx_power: type logic but that should probably have instead been made explicitly into a new test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements zigpy/zigpy#1686 and zigpy/zigpy#1687. Requires NabuCasa/silabs-firmware-builder#118.