Skip to content

Reduce RST cancel prefix to 32 bytes #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Reduce RST cancel prefix to 32 bytes #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bellows/ash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,4 +719,4 @@ async def send_data(self, data: bytes) -> None:

def send_reset(self) -> None:
# Some adapters seem to send a NAK immediately but still process the reset frame
self._write_frame(RstFrame(), prefix=40 * (Reserved.CANCEL,))
self._write_frame(RstFrame(), prefix=32 * (Reserved.CANCEL,))
2 changes: 1 addition & 1 deletion tests/test_ash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ async def test_ash_protocol_startup(caplog):

assert ezsp.reset_received.mock_calls == [call(t.NcpResetCode.RESET_SOFTWARE)]
assert protocol._write_frame.mock_calls == [
call(ash.RstFrame(), prefix=40 * (ash.Reserved.CANCEL,))
call(ash.RstFrame(), prefix=32 * (ash.Reserved.CANCEL,))
]

protocol._write_frame.reset_mock()
Expand Down
Loading