Skip to content

Conversation

@corvis
Copy link
Contributor

@corvis corvis commented Mar 25, 2024

Proposed change

This quirk adds support for power on behavior configuration to Aqara Light T1M (ceiling light with RGB ring).
This device identifies itself as lumi.light.acn032.

Additional information

Resolves #3066

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This quirk adds support for power on behavior configuration
@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (4b3d659) to head (6236e95).
Report is 350 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3070      +/-   ##
==========================================
+ Coverage   87.91%   87.93%   +0.01%     
==========================================
  Files         301      301              
  Lines        9229     9244      +15     
==========================================
+ Hits         8114     8129      +15     
  Misses       1115     1115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@corvis
Copy link
Contributor Author

corvis commented Mar 25, 2024

Also I think it would be nice to expose this option as a configuration entity in UI preferably in as a drop-down. Can anyone point me into an relevant example?

@dmulcahey
Copy link
Collaborator

@jrseliga
Copy link

jrseliga commented Apr 4, 2024

@corvis might be outside the scope of this PR, but it would be awesome if the ring light effects could also be exposed.

I saw some indications this may be already be available in Zigbee2MQTT

@corvis
Copy link
Contributor Author

corvis commented Apr 5, 2024

I do not have capacity to reverse engineer the protocol but if there is already a working solution in Zigbee2MQTT or any other project i can back port it in ZHA. @jrseliga can you point me into the code\PR\whatever else indications you've mentioned?

@jrseliga
Copy link

jrseliga commented Apr 5, 2024

@corvis the Make It Work Youtube channel reviewed the Aqara T1M. There was a brief mention of using this device with Zigbee2MQTT. He mentioned it was not reliable, but you will notice the effects dropdown at the the bottom.

That link is right at the timestamp where he discusses Zigbee2MQTT with the Aqara T1M.

I had a look through Zigbee2MQTT repository but couldn't pinpoint what may be exposing that specific feature.

@StephenBrown2
Copy link

Any chance of this getting merged any time soon? I would love to be able to set my ceiling lights to PreserveState on power restoration.

PROFILE_ID: zha.PROFILE_ID,
DEVICE_TYPE: zha.DeviceType.COLOR_DIMMABLE_LIGHT,
INPUT_CLUSTERS: [
BasicCluster.cluster_id, # 0x0000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these comments at the end everywhere? We don't really use them in our repo and it should be kept consistent.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yeah, if this were a v2 quirk, we can directly add the config entity.
There's some docs in a draft PR.

@TheJulianJES TheJulianJES added the help wanted Extra attention is needed label Aug 3, 2024
@svensol
Copy link

svensol commented Aug 4, 2024

Any chance of this getting merged any time soon? I would love to be able to set my ceiling lights to PreserveState on power restoration.

I would love to know this too. My support request to Aqara told me to buy a hub to get this feature.

This may be off-topic, but forgive my lack of knowledge: when this is merged into zigpy:dev, how long does it take to make into the mainline prod? I.e. will it take a couple of months before it’s in the regular updates, or would it be quicker for me to learn how to make a custom quirk? (I don’t want to buy more equipment unless I have to)

Thanks, all!

@mathiasolofsson
Copy link

Would love to know if this is planned to be merged in the near future as well as I have the same issue with the lights coming on now and then.

@jdumas
Copy link

jdumas commented Jan 3, 2025

Hi. I recently installed two T1M in my room and integrated them directly into HA (without the Aqara Hub). While for the most part it works out of the box (I can control both the main light and the ring separately), I'm having issues trying to turn it on/off. Specifically, I'm observing the following behavior:

  1. When turning the lights off directly via the HA dashboard, they would turn back on immediately after.
  2. When turning the lights off via an automation (programmed a Lutron Pico remote), the ring lights tend to stay lit with a dim setting. I have to send the lights off command multiple times to actually succeed.
  3. When turning the lights on (via the same Pico remote) it sometimes doesn't work (nothing happens).

Now, these two lights are connected to a Lutron Diva Smart Dimmer (currently waiting for the Inovelli Blue that have a smart bulb mode), which I keep on max all the time. I don't have a neural at the dimmer switch. Finally, I have both Aqara lights hooked up to the Adaptive Lighting integration, which works quite well once the light are turned on...

Anyhow I'd like to try the updates in this PR to see if it would solve the turn on/off issues I've described above. I'm not quite sure how to try the changes, so if you can advise on that that'd be great. Thanks!

@evanjarrett
Copy link
Contributor

This can be closed now that #4136 is merged

@TheJulianJES
Copy link
Collaborator

@corvis Thanks for your PR and initial implementation! We've gone with PR #4136 now, as that implements this in a v2 quirk and also exposes the "power on state" entity directly.
But again, still thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Support Request] Aqara Ceiling light T1M

10 participants