Skip to content

Initial quirk for Bosch Twinguard smoke detector #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

sarangnemo
Copy link

Proposed change

Add initial support for Bosch Twinguard, partially addressing this issue. Allows reading of temperature, humidity, illuminance, and raw VOC values. Smoke detection and alarm functions not yet implemented.

Additional information

In my experience, the measurement values begin reporting some minutes after pairing. I also needed to restart HA to see the new sensors.

The original TemperatureMeasurement, HumidityMeasurement, and IlluminanceMeasurement clusters are removed, since they do not self-update. (They would, however, update on explicit cluster read.) These measurements are instead reported every 5 minutes on manufacturer-specific Cluster 0xE002 (Endpoint 3), so this PR primarily adds support for reading in this cluster and pushing the data to standard clusters.

Checklist

  • [X ] The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label Feb 23, 2025
@sarangnemo
Copy link
Author

I'm a noob with contributing quirks. What should I do to get these tests to pass?

@TheJulianJES TheJulianJES added the needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). label Feb 23, 2025
@github-actions github-actions bot removed the stale Issue is inactivate and might get closed soon label Feb 24, 2025
@TheJulianJES TheJulianJES added the help wanted Extra attention is needed label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants