-
Notifications
You must be signed in to change notification settings - Fork 796
Decompose attribute_name
tuple to new DP mapping list format
#3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abmantis
wants to merge
7
commits into
zigpy:dev
Choose a base branch
from
abmantis:deprecate_tupple_dptoattributemapping
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Decompose attribute_name
tuple to new DP mapping list format
#3986
abmantis
wants to merge
7
commits into
zigpy:dev
from
abmantis:deprecate_tupple_dptoattributemapping
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3986 +/- ##
==========================================
+ Coverage 91.19% 91.22% +0.02%
==========================================
Files 335 335
Lines 10886 10920 +34
==========================================
+ Hits 9928 9962 +34
Misses 958 958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abmantis
commented
Mar 26, 2025
…cate_tupple_dptoattributemapping
…cate_tupple_dptoattributemapping
attribute_name
tuple to new DP mapping list format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs review
This PR should be reviewed soon, as it generally looks good.
Tuya
Request/PR regarding a Tuya device
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Requires #3977.As previously discussed in #3643, this converts the old tuple in DPToAttributeMapping to the new list of DPToAttributeMapping.
For this, the
dp_converter
also needs to be wrapped and a new attributes_to_dp_converters attribute was introduced in TuyaMCUCluster.In a follow-up PR I'll add support to the TuyaQuirkBuilder for the new
dp_converter
. Eventually, after migrating all existing clusters and quirks to the new format we could change the deprecation info logs in DPToAttributeMapping to warnings, so we can clean up the code after some time.Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black