Skip to content

Add Yandex devices: YNDX-00530, 00531, 00532, 00537, 00538 #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Nullcaller
Copy link

@Nullcaller Nullcaller commented Apr 2, 2025

Proposed change

Add support for manufacturer-specific features of the following Yandex devices:

  • YNDX-00530 Dimmer
  • YNDX-00531 Single-gang Switch
  • YNDX-00532 Double-gang Switch
  • YNDX-00537 Single Relay
  • YNDX-00538 Double Relay

(Sidenote: YNDX-00534 and YNDX-00535 wireless switches are a thing, but they work fine without a quirk, imo)

Additional information

I've used code from Koenkk/zigbee-herdsman-converters#8345 and Koenkk/zigbee-herdsman-converters#9017 as reference for cluster attributes and commands.

Known issues:

  • The led_indicator attribute is weird, I don't think it's working as it should on all devices.
  • When adding devices, they get stuck in "Configuring" stage for a long while, but eventually get added (a restart of Home Assistant helps)
  • If SKIP_CONFIGURATION: True is added to replacement signature, devices don't get stuck in "Configuring" stage, but attribute reporting doesn't work
  • After adding double-gang switch or double relay, attribute reporting may not work for the second endpoint, which somehow gets fixed after pressing 'Reconfigure' on device page in HA
  • Some of the endpoints added in replacement signatures are 'fake' and only work if the device is set into a 'decoupled' mode, if the endpoints are used in HA in any way when the device is not in the 'decoupled' mode, HA hangs until the requests time out.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

YNDX-00530
YNDX-00531
YNDX-00532
YNDX-00537
YNDX-00538
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (2fd3586) to head (6e95028).
Report is 21 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3999      +/-   ##
==========================================
+ Coverage   91.04%   91.27%   +0.23%     
==========================================
  Files         331      336       +5     
  Lines       10698    10983     +285     
==========================================
+ Hits         9740    10025     +285     
  Misses        958      958              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nullcaller
Copy link
Author

Nullcaller commented Apr 2, 2025

I think the biggest issue with this quirk at this point is the ability to toggle the OnOff clusters in 'fake' endpoints (which only become 'real' in decoupled mode) from HA. If someone can point me in the general direction of a solution for this problem, that'd be greatly appreciated. Some of my inklings of a thought of an idea:

  • Is there a way to make endpoints/clusters/ha entities read-only?
  • Is there a way to make replacement signatures dynamic, i.e. dependent on an attribute value?

@TheJulianJES TheJulianJES added needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). v2 quirk candidate This PR is a good fit to be converted to a v2 quirk. labels Apr 29, 2025
@TheJulianJES TheJulianJES changed the title Add support for Yandex devices: YNDX-00530, YNDX-00531, YNDX-00532, YNDX-00537 and YNDX-00538 Add Yandex devices: YNDX-00530, 00531, 00532, 00537, 00538 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). v2 quirk candidate This PR is a good fit to be converted to a v2 quirk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants