-
Notifications
You must be signed in to change notification settings - Fork 960
Add Yandex devices: YNDX-00530, 00531, 00532, 00534, 00535, 00537, 00538, 00591 #3999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
YNDX-00530 YNDX-00531 YNDX-00532 YNDX-00537 YNDX-00538
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3999 +/- ##
==========================================
+ Coverage 91.04% 91.41% +0.36%
==========================================
Files 331 341 +10
Lines 10698 11130 +432
==========================================
+ Hits 9740 10174 +434
+ Misses 958 956 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
As this quirk is quite basic, I don't really know whether it needs any tests. There is nothing functionally new to test here. It's all just wrapper classes, attributes and commands. I have tested it with pretty much all devices, though. It does work. |
|
For anyone wanting to use the quirk before it is merged, I've compiled the quirk into a single file and made a gist: https://gist.github.com/Nullcaller/746f3a44ff694043c1141a84e66c4483 |
Proposed change
Add support for manufacturer-specific features of the following Yandex devices:
(YNDX-00534 and YNDX-00535 wireless switch quirks are only really there for automation triggers' sake)
Additional information
I've used code from Koenkk/zigbee-herdsman-converters#8345 and Koenkk/zigbee-herdsman-converters#9017 as reference for cluster attributes and commands.
Known issues:
Known issues (fixed):
Dimmer is pretty much untested. I'll test it when I have time.Some of the endpoints added in replacement signatures are 'fake' and only work if the device is set into a 'decoupled' mode, if the endpoints are used in HA in any way when the device is not in the 'decoupled' mode, HA hangs until the requests time out.Known issues (wontfix):
SKIP_CONFIGURATION: Trueis added to replacement signature, devices don't get stuck in "Configuring" stage, but attribute reporting doesn't workChecklist
pre-commitchecks pass / the code has been formatted using Black