Add Sonoff smart plug S60ZBTPF quirk #4031
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4031 +/- ##
==========================================
+ Coverage 91.19% 91.21% +0.01%
==========================================
Files 335 337 +2
Lines 10886 10950 +64
==========================================
+ Hits 9928 9988 +60
- Misses 958 962 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| async def _read_attributes( | ||
| self, | ||
| attribute_ids: list[t.uint16_t], | ||
| *args, | ||
| manufacturer: int | t.uint16_t | None = None, | ||
| **kwargs, | ||
| ): | ||
| """Read attributes ZCL foundation command.""" | ||
| return await super()._read_attributes( | ||
| attribute_ids, | ||
| *args, | ||
| manufacturer=foundation.ZCLHeader.NO_MANUFACTURER_ID, | ||
| **kwargs, | ||
| ) | ||
|
|
||
| @property | ||
| def _is_manuf_specific(self): | ||
| return False |
There was a problem hiding this comment.
We should be able to set manufacturer_id_override for the cluster instead.
See as an example:
| async def _read_attributes( | ||
| self, | ||
| attribute_ids: list[t.uint16_t], | ||
| *args, | ||
| manufacturer: int | t.uint16_t | None = None, | ||
| **kwargs, | ||
| ): | ||
| """Read attributes ZCL foundation command.""" | ||
| return await super()._read_attributes( | ||
| attribute_ids, | ||
| *args, | ||
| manufacturer=foundation.ZCLHeader.NO_MANUFACTURER_ID, | ||
| **kwargs, | ||
| ) | ||
|
|
||
| @property | ||
| def _is_manuf_specific(self): | ||
| return False |
There was a problem hiding this comment.
Same comment as above here:
We should be able to set manufacturer_id_override for the cluster instead. See as an example:
zhaquirks/sonoff/s60zbtpf.py
Outdated
| # network_led = ZCLAttributeDef( | ||
| # name="network_led", | ||
| # id=0x0001, | ||
| # type=t.Bool, | ||
| # ) |
There was a problem hiding this comment.
Does this attribute not work? If so, it can be removed. We shouldn't add commented code.
If the attribute does work, we can define it here (so just uncomment). We don't have to necessarily add a config entity for all attributes (although it might make sense for this attribute).
zhaquirks/sonoff/s60zbtpf.py
Outdated
| # .enum( | ||
| # SonoffCluster.AttributeDefs.network_led.name, | ||
| # SonoffNetworkLedSetType, | ||
| # 0xFC11, | ||
| # translation_key = "network_led", | ||
| # fallback_name = "Network led", | ||
| # ) |
There was a problem hiding this comment.
Related to the comment above regarding the network_led attribute:
Does this not work? Should this be a switch instead?
zhaquirks/sonoff/s60zbtpg.py
Outdated
| .add_to_registry() | ||
| ) | ||
|
|
||
| # class SonoffS60zb(CustomDevice): |
There was a problem hiding this comment.
Please remove this commented line.
TheJulianJES
added
waiting for changes
|
@TheJulianJES I have already made the changes. |
Proposed change
Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black