v2 quirk for Bosch light/cover control relay II (BMCT-SLC / RBSH-MMS-ZB-EU)

[jeverley]

Proposed change

This quirk also overrides the window_covering_type from the tilt only Shade type, to Tilt_blind_tilt_and_lift because the device is a generic relay supporting commands for both lift and tilt.

Uses https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/bosch.ts as reference for exposing the device's configuration and status entities.

zigbee2mqtt supports the ability to manage entity availability depending on a device attribute value (in this case it exposes light entities when the device is in light mode, and the cover entity when in shade mode).
ZHA can't currently do this, so instead users will need to disable the redundant entities based on their configuration.

Additional information

• Adds support for the device [Device Support Request] Bosch Light/shutter control II (BMCT-SLZ) #2518
• Addresses issue Bosch Shutter Control II (BMCT-SLZ aka RBSH-MMS-ZB-EU) has no controls for up / down since 2025.4.3 home-assistant/core#143875

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (5556090) to head (253ebd2).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #4052      +/-   ##
==========================================
+ Coverage   91.19%   91.22%   +0.02%     
==========================================
  Files         335      336       +1     
  Lines       10886    10921      +35     
==========================================
+ Hits         9928     9963      +35     
  Misses        958      958              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jeverley]

Looping in initial testing feedback from home-assistant/core#143875 (comment)

Hi @stylefish, the duration entities should now be working (latest version in https://github.com/zigpy/zha-device-handlers/pull/4052/files).
They were missing the multiplier value - please can you confirm they now reflect your configured value in the UI?

I've also updated the motor_state to use the sensor entity type.

oh wow - thank you @jeverley !

yes, the shutters are working again! :)

i've attached a screenshot of one device:

https://github.com/user-attachments/assets/0da1479a-cda6-4338-9ff6-5e750f7fb05e

https://github.com/user-attachments/assets/9aa008f2-4e93-4bb3-b20b-d0e84d1be794

i would've liked to attach another diagnostic json, but somehow i'm getting an error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.13/site-packages/aiohttp/web_protocol.py", line 510, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/aiohttp/web_app.py", line 569, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 86, in ban_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 242, in auth_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 41, in headers_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle
    result = await handler(request, **request.match_info)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/diagnostics/__init__.py", line 301, in get
    data = await info.device_diagnostics(hass, config_entry, device)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/zha/diagnostics.py", line 114, in async_get_device_diagnostics
    diagnostics_json: dict[str, Any] = zha_device_proxy.device.get_diagnostics_json()
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/local/lib/python3.13/site-packages/zha/zigbee/device.py", line 1378, in get_diagnostics_json
    "state": platform_entity.state,
             ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/zha/application/platforms/number/__init__.py", line 284, in state
    response["state"] = self.native_value
                        ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/zha/application/platforms/number/__init__.py", line 290, in native_value
    value = self._cluster_handler.cluster.get(self._attribute_name)
  File "/usr/local/lib/python3.13/site-packages/zigpy/quirks/__init__.py", line 412, in get
    attr_def = self.find_attribute(key)
  File "/usr/local/lib/python3.13/site-packages/zigpy/zcl/__init__.py", line 240, in find_attribute
    raise ValueError(  # noqa: TRY004
    ...<2 lines>...
    )
ValueError: Attribute must be either a string or an integer, not ZCLAttributeDef(id=0x0002, name='calibration_opening_time', type=, zcl_type=, access=, mandatory=False, is_manufacturer_specific=True) (

is this related or is this another issue?

anyway, it would be great if this could be mainlined! the shutters are working great, though i noticed, that "opening_duration" and "closing_duration" and some other options are "disabled" with the info This entity is no longer being provided by the zha integration. If the entity is no longer in use, delete it in settings.

is this due to the previous quirk?

the settings can be read/write from the "manage device" dialog, this was also the case for the previous quirk:

https://github.com/user-attachments/assets/e92e2fc9-e03b-4def-9090-a69b64d52a90

i'm happy to help to integrate this into mainline.

thanks again, i'm very happy with my working shutters on 2025.5.0 :)

[stylefish]

sorry for commenting on the issue, i've read the edit after start composing my reply.

no luck, the fields are still empty:

they're looking like this when opened:

and i'm still unable to get the diagnostic json.

[jeverley]

no luck, the fields are still empty:

Thanks for checking @stylefish, 253ebd2 should resolve this.

[stylefish]

yes, it works now - i have changed the values and they're persisted:

the disabled ones are from the old quirk and can be removed, right?

[jeverley]

the disabled ones are from the old quirk and can be removed, right?

Yes that's correct.

[TomF79]

Many thanks for your fantastic Support and work on this @jeverley and @stylefish

So i dont need the custom quirk folder and py file anymore when this PR is merged and in the next Core Update from Home Assistant?