-
Notifications
You must be signed in to change notification settings - Fork 824
v2 quirk for Bosch light/cover control relay II (BMCT-SLC / RBSH-MMS-ZB-EU) #4052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Uses https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/bosch.ts for reference Overrides the window_covering_type from `Shade` (tilt) to `Tilt_blind_tilt_and_lift` because the device is a generic relay supporting commands for both lift and tilt. pre-commit fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4052 +/- ##
==========================================
+ Coverage 91.19% 91.22% +0.02%
==========================================
Files 335 336 +1
Lines 10886 10921 +35
==========================================
+ Hits 9928 9963 +35
Misses 958 958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looping in initial testing feedback from home-assistant/core#143875 (comment) Hi @stylefish, the duration entities should now be working (latest version in https://github.com/zigpy/zha-device-handlers/pull/4052/files). I've also updated the
|
cc04727
to
2139c07
Compare
Thanks for checking @stylefish, 253ebd2 should resolve this. |
Yes that's correct. |
Many thanks for your fantastic Support and work on this @jeverley and @stylefish So i dont need the custom quirk folder and py file anymore when this PR is merged and in the next Core Update from Home Assistant? |
Is it possible to integrate settings for:
These two options also included in the settings from the Bosch smart Home App, so they are should configurable on the device. |
Hi @TomF79, my understanding from the z2m quirk attribute mappings is that you should be able to use the 'Opening duration' and 'Closing duration' Configuration entities that I've exposed to manage the opening/closing time. When you say tilt angle 90 or 180 degrees, would you be able to share a screenshot of Bosch setting you're referring to? |
I will send a Screenshot at the evening. Yes this will controlling the device tilt position. There is one option to Control up and down with opening/closing time and one option to Control the tilt Position with Travel time in the Bosch App under the device. I think the Travel time makes a different especially for tilt if it is for 90 or 180 degrees. |
Here are some Screenshots: I have copy your actual v2 quirk file to my custom quirk folder. The Relay Lift is working up and down correctly, but the Tilt doesnt works for me. Maybe @stylefish can also test this? |
sorry - no. my shutters do not support tilt. |
Thanks for reply. Maybe @sopelt could help to get the tilt working? |
@TomF79 we'll need to identify the attribute IDs for controlling this configuration (z2m doesn't seem to have identified them). Are you able to move the tilt at all using the home assistant tilt commands? These should be visible on the right if you click on the cover like below: I can try and make some experimental versions of the quirk to try and find the right IDs to control the tilt config. |
I am not able to move the tilt at all using the home assistant tilt commands. Tilt only works in the Bosch App and in HA with BoschSHC Integration when the relay is connected to the Bosch Controller. |
Test using
On external motor operated blinds. |
Proposed change
This quirk also overrides the
window_covering_type
from the tilt onlyShade
type, toTilt_blind_tilt_and_lift
because the device is a generic relay supporting commands for both lift and tilt.Uses https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/bosch.ts as reference for exposing the device's configuration and status entities.
zigbee2mqtt supports the ability to manage entity availability depending on a device attribute value (in this case it exposes light entities when the device is in light mode, and the cover entity when in shade mode).
ZHA can't currently do this, so instead users will need to disable the redundant entities based on their configuration.
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black