Add Third Reality curtain_gen1 settings #4378
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4378 +/- ##
=======================================
Coverage 92.12% 92.13%
=======================================
Files 358 359 +1
Lines 11917 11928 +11
=======================================
+ Hits 10979 10990 +11
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
added
the
manufacturer
Comment on lines
+42
to
+48
| .write_attr_button( | ||
| attribute_name=ThirdRealityCurtainCluster.AttributeDefs.allow_bind.name, | ||
| attribute_value=0x01, | ||
| cluster_id=ThirdRealityCurtainCluster.cluster_id, | ||
| translation_key="allow_bind", | ||
| fallback_name="Allow bind", | ||
| ) |
There was a problem hiding this comment.
What does "Allow bind" do exactly? Is this related to cluster binding or to curtains being bound?
Does the device reset the value from 1 to 0 itself after this button is pressed?
There was a problem hiding this comment.
For example, sending a bind request to the button, opening the bind, the curtain can send a request to establish contact, triggering an allow bind once, which can last for three minutes
There was a problem hiding this comment.
After writing 1, wait for 3 minutes until the end, and this value will become 0
TheJulianJES
added
the
waiting for reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR added adaptation code for curtain_gen1 and added 2 additional private clusters
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black