-
Notifications
You must be signed in to change notification settings - Fork 902
Fix long release dim down for Ikea 2 button remote (Rodret) #4433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
57fff7a to
feaf79c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4433 +/- ##
==========================================
- Coverage 92.12% 92.05% -0.08%
==========================================
Files 358 358
Lines 11917 11935 +18
==========================================
+ Hits 10979 10987 +8
- Misses 938 948 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I dont knowing if its working then i have not the coding knowledge but i think its great that is being implemented !! |
|
I can rename it to |
|
Since there are no tests for those 2 button remotes at all, I tried to setup some but I am not quite sure where can I get NodeDescriptor in a format as in other tests. The JSON copied from device signature view in ZHA doesn't match in test that I've included in below. The README example also has NodeDescriptor() example but no info about how get this exact format. Example signature matching test case
def test_ikea_2btnremote(assert_signature_matches_quirk):
"""Test new 'Tradfi,Rodret table' signature is matched to its quirk."""
|
Proposed change
This PR is implementing long release dim down action support similar to https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/ikea/opencloseremote.py
This should resolve #2024
Additional information
Since
stop_with_on_offevent is no longer bound to replacements, it will be fired as well and is be visible in device's activity log.Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black