Skip to content

Conversation

@anssih
Copy link

@anssih anssih commented Dec 14, 2025

Proposed change

My Aqara H1 double rocker no-neutral switch is the same as AqaraH1DoubleRockerSwitchNoNeutral except it has no endpoints 41, 42, 51.

Add that.

Additional information

Device diagnostics

  "data": {
    "version": 1,
    "ieee": "**REDACTED**",
    "nwk": "0xF3D7",
    "manufacturer": "LUMI",
    "model": "lumi.switch.l2aeu1",
    "friendly_manufacturer": "LUMI",
    "friendly_model": "lumi.switch.l2aeu1",
    "name": "LUMI lumi.switch.l2aeu1",
    "quirk_applied": false,
    "quirk_class": "zigpy.device.Device",
    "exposes_features": [],
    "manufacturer_code": 4447,
    "power_source": "Battery or Unknown",
    "lqi": 168,
    "rssi": -69,
    "last_seen": "2025-12-14T12:37:35.462463+00:00",
    "available": true,
    "device_type": "EndDevice",
    "active_coordinator": false,
    "node_descriptor": {
      "logical_type": "EndDevice",
      "complex_descriptor_available": false,
      "user_descriptor_available": false,
      "reserved": 0,
      "aps_flags": 0,
      "frequency_band": 8,
      "mac_capability_flags": 128,
      "manufacturer_code": 4447,
      "maximum_buffer_size": 127,
      "maximum_incoming_transfer_size": 100,
      "server_mask": 11264,
      "maximum_outgoing_transfer_size": 100,
      "descriptor_capability_field": 0
    },
    "endpoints": {
      "1": {
        "profile_id": 260,
        "device_type": {
          "name": "ON_OFF_LIGHT",
          "id": 256
        },
        "in_clusters": [
          {
            "cluster_id": "0x0000",
            "endpoint_attribute": "basic",
            "attributes": [
              {
                "id": "0x0006",
                "name": "date_code",
                "zcl_type": "string",
                "value": "01-12-2021"
              },
              {
                "id": "0x0004",
                "name": "manufacturer",
                "zcl_type": "string",
                "value": "LUMI"
              },
              {
                "id": "0x0005",
                "name": "model",
                "zcl_type": "string",
                "value": "lumi.switch.l2aeu1"
              }
            ]
          },
          {
            "cluster_id": "0x0002",
            "endpoint_attribute": "device_temperature",
            "attributes": [
              {
                "id": "0x0000",
                "name": "current_temperature",
                "zcl_type": "int16",
                "value": 30
              }
            ]
          },
          {
            "cluster_id": "0x0003",
            "endpoint_attribute": "identify",
            "attributes": []
          },
          {
            "cluster_id": "0x0004",
            "endpoint_attribute": "groups",
            "attributes": []
          },
          {
            "cluster_id": "0x0005",
            "endpoint_attribute": "scenes",
            "attributes": [
              {
                "id": "0xfffd",
                "name": "cluster_revision",
                "zcl_type": "uint16",
                "value": 1
              }
            ]
          },
          {
            "cluster_id": "0x0006",
            "endpoint_attribute": "on_off",
            "attributes": [
              {
                "id": "0x0000",
                "name": "on_off",
                "zcl_type": "bool",
                "value": 1
              },
              {
                "id": "0x4003",
                "name": "start_up_on_off",
                "zcl_type": "enum8",
                "unsupported": true
              }
            ]
          },
          {
            "cluster_id": "0x0012",
            "endpoint_attribute": "multistate_input",
            "attributes": [
              {
                "id": "0x004a",
                "name": "number_of_states",
                "zcl_type": "uint16",
                "value": 6
              },
              {
                "id": "0xfffe",
                "name": "reporting_status",
                "zcl_type": "enum8",
                "unsupported": true
              },
              {
                "id": "0x000e",
                "name": "state_text",
                "zcl_type": "unk",
                "unsupported": true
              }
            ]
          },
          {
            "cluster_id": "0xfcc0",
            "endpoint_attribute": "manufacturer_specific",
            "attributes": []
          }
        ],
        "out_clusters": [
          {
            "cluster_id": "0x000a",
            "endpoint_attribute": "time",
            "attributes": []
          },
          {
            "cluster_id": "0x0019",
            "endpoint_attribute": "ota",
            "attributes": [
              {
                "id": "0x0002",
                "name": "current_file_version",
                "zcl_type": "uint32",
                "value": 3595
              }
            ]
          }
        ]
      },
      "2": {
        "profile_id": 260,
        "device_type": {
          "name": "ON_OFF_LIGHT",
          "id": 256
        },
        "in_clusters": [
          {
            "cluster_id": "0x0000",
            "endpoint_attribute": "basic",
            "attributes": []
          },
          {
            "cluster_id": "0x0003",
            "endpoint_attribute": "identify",
            "attributes": []
          },
          {
            "cluster_id": "0x0004",
            "endpoint_attribute": "groups",
            "attributes": []
          },
          {
            "cluster_id": "0x0005",
            "endpoint_attribute": "scenes",
            "attributes": []
          },
          {
            "cluster_id": "0x0006",
            "endpoint_attribute": "on_off",
            "attributes": [
              {
                "id": "0x0000",
                "name": "on_off",
                "zcl_type": "bool",
                "value": 0
              },
              {
                "id": "0x4003",
                "name": "start_up_on_off",
                "zcl_type": "enum8",
                "unsupported": true
              }
            ]
          },
          {
            "cluster_id": "0x0012",
            "endpoint_attribute": "multistate_input",
            "attributes": []
          },
          {
            "cluster_id": "0xfcc0",
            "endpoint_attribute": "manufacturer_specific",
            "attributes": []
          }
        ],
        "out_clusters": []
      },
      "242": {
        "profile_id": 41440,
        "device_type": {
          "name": "PROXY_BASIC",
          "id": 97
        },
        "in_clusters": [],
        "out_clusters": [
          {
            "cluster_id": "0x0021",
            "endpoint_attribute": "green_power",
            "attributes": []
          }
        ]
      }
    },

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

My Aqara H1 double rocker no-neutral switch is the same as
AqaraH1DoubleRockerSwitchNoNeutral except it has no endpoints 41, 42,
51.

Add that.
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.28%. Comparing base (35d1fc1) to head (df9b546).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4571   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         371      371           
  Lines       12158    12160    +2     
=======================================
+ Hits        11220    11222    +2     
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant