Fix custom divisor for Innr SP 240 on 0x191E3685

[TheJulianJES]

Proposed change

This quirk removes changing the divisor for Innr SP 240 plugs on firmware 0x191E3685 and later.

As old divisor values from the quirk may have persisted into zigpy cache, a quirk for newer versions is also added to force the correct divisor: 1000. This avoids users needing to re-pair devices to fix the issue and also allows OTA upgrades without re-pairing the device (just needing a ZHA reload or HA restart).

The config entities for the LevelControl cluster are also hidden.

Additional information

Tested with the SP 240 (on a much newer version than the latest OTA).

Fixes:

• Addresses [BUG] Innr SP240 newest firmware not compatible anymore with the quirk #3857
• Addresses [BUG] INNR SP 240 "summation delivered" kWh value is 100x expected value #2781

Device diagnostics

Freshly paired without quirk:
Innr SP 240 without quirk zha-01KAH6BZ8GBKBJXCPX8V4BB4KP-innr SP 240-40d6d753fef0dfeafea5ce24ed764473.json

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works
• Device diagnostics data has been attached

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.28%. Comparing base (35d1fc1) to head (111460e).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #4592      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         371      371              
  Lines       12158    12155       -3     
==========================================
- Hits        11220    11217       -3     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TheJulianJES]

Hmm, this does not work. The quirk still always applies. Only if allow_missing=False is added will the quirk (never) apply. Will take a look..
I hope we just load everything early enough for the filter to even work at all.

[TheJulianJES]

Yeah... It seems like we only load attributes after we do the software version check. So, it'll never work.

[TheJulianJES]

This correctly works with zigpy/zigpy#1735 now. The remaining related "issues" are:

• The other plugs should also be fixed. Waiting on feedback here: [BUG] Innr SP240 newest firmware not compatible anymore with the quirk #3857 (comment)
• OTA current_file_version isn't read early enough when pairing, so we default to the new quirk now (divisor: 1000).
  If a device on an old version is paired, the divisor will fix itself after restarting. With Read OTA info for newly joining devices zigpy#1631, this should be fixed entirely.
• We should eventually also allow for "device reconfiguration" to re-read a bunch of attributes only read on initial pairing.
• When updating the device, ZHA needs to be reloaded once (or HA restarted) in order to change to the new quirk.

Except for fixing the other Innr plug models, everything else needs to be addressed in zigpy/ZHA. This PR should be good to go. We can fix other the other Innr plug in another PR.