-
Notifications
You must be signed in to change notification settings - Fork 960
Add support for IKEA Bilresa 2 button remote #4612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4612 +/- ##
==========================================
+ Coverage 92.28% 92.29% +0.01%
==========================================
Files 371 372 +1
Lines 12158 12176 +18
==========================================
+ Hits 11220 11238 +18
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great work done !!First what not working that is implemented: so must being Its possible "saving" the last long press and using it for tagging the release with it like is being done in the Open/Close control. zha-device-handlers/zhaquirks/ikea/opencloseremote.py Lines 66 to 76 in 35d1fc1
I was looking before Christmas and was not doing one quirk then its looks like the DA for move is broken also for all existing device so i was doing one bug report for getting it fixed and then can implementing the DA for the new device. #4605 Now to the not implemented parts: And the device is sending IKEAs scene commands on double press so need putting it in (copy from Styrbar). Adding this imports: and need some more commands imported: And then replace PowerConfig and scene cluster with the imported ones_ Now we can adding the DA for scene changes: Then the move command DA is fixed we only have one problem left and its naming of the button. Its not OK haveing 2 diferent named of one button (On/dim up / Off/dim down) it shall being the same name and only changing the command / function that is being triggered. So On/off , Dim Up/Down or Upper/Lower button. I was having one forbutton / styrbar modded quirk working but have copy yours and all is working OK (move not) and looks nice but this device is not good as light controller then its not honer group and device bindings in Zigbee mode and only sending commands to IKEA scene groups so if having more lights is sending commands to all and cant being changed what i knowing (can being more digging is needed but wireshark is showing the remote is acking the bind command but not using it and delete all bindings) but still baseball for doing automation with but better with matter over thread (that have not implemented binding cluster and its not sending light commands = no go for lights if like have god functionality). One more time great work done !!! |
|
Just press the button 8 times. You don't need to press 4 times first. The rule for new Ikea Matter devices, if you want to use them in Zigbee, is that you do 2 times more than for regular Zigbee devices. Examples:
|
|
All working except move DAs that is broken in zigpy and dim down long release triggering long up release: PS: Bilresa scroll weal is also in the quirk for test only for getting the scene commands OK but no DA is implemented for it (double and tipple press). |
|
Very true @mkz212 and i hope its working for all lights and upcoming plugs but we will see in the future. IKEA have not implemented OTA cluster (and stripped other tings 2 like manufacture name and so on) on the devise i have looking on but updates looks working OK from Matter for the device that is having new firmware released. |
|
This is interesting. This is doubling the battery for me to 200% This is not working for me:
though the corresponding DIM_DOWN is working. The I swear last night that the long press release for up and down were both working, but I might have just been looking at one trigger fire at a time. It was late. 😄 Double clicks are working! 👍 👍 I am going to dig into this a bit more.
|
|
Was testing some "native" IKEA Zigbee controllers that use "IKEA scene" and all is sending the same events but the DA is broken for all (move with and without off) and TS004F is using step and also looks broken. The battery remaining im not 100% if its reporting 100 for full or true Zigbee = 200 for full and 256 for NA and displaying it *0.5 but i think its more bad implemented hard / software then the readings looks the same then connected with Matter. If you are good with coding implementing the function from Open/Close that "remember" the last up/down long pressed and tagging the release with it its only some line of code but im not one code worrier so cant doing it. You are correct i was doing the normal copy/past thing. And cant testing it then the DA for move is not working. |
|
I removed the device, restarted HA again, then re-paired the device again. Removing this fixes the battery percentage doubling. These are all working for me (except for long press dim down release for the reason you noted): I will look into the code that remembers the last long press. |
|
Was fixing the long press up with only move and restarting HA and adding one automation for it and its working with notification being triggered so all is in now !!! Only think i dont like turn On/Off / DimUp/Down for the same button (the name of it that is showing up in the automation). |
|
Thanks for the hint about remembering the move command that started the long press. This should be working for the long press releases. 👍 I removed the battery adjustment because it is definitely doubling it for me. Maybe there needs to be some other adjustment made to how it's calculated; I am not sure. EDIT: pasted wrong quirk version |
|
Was adding the double and restarting HA and doing DA for long press up and down and all is working great !!!! Was looking more on the scroll weal but we is missing move to level command that need being added in the consts so not easy testing then must patching little and only fir getting not good working functionality so no go for the moment. |
|
One question. |
I can do that, but to be clear, that means the quirk in this PR can't be used until the PR is (hopefully) merged, correct? If people want to use a custom quirk for this before it is merged then they'd need to use a version with the level control in the quirk. |
|
That shall not being any problem if they is using the last version you posted it have it inside so working as "standalone". |
|
Here is a working standalone quirk until this is (hopefully) merged: |
Great work done !!!and large thanks for getting all working well. |
|
Thanks for your help! |
MattWestb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good done and large thanks for making the "remember last long pressed" in IKEA init so we can using it for other devices that dont have it implemented.
Proposed change
This quirk v2 adds device automation triggers for the new Bilresa 2 button remote:
press on,hold on,hold on released,press off,hold off,hold off released.To pair in ZHA
Additional information
Device diagnostics
zha-cf326f00bf27144eb946b7dd7295081c-IKEA of Sweden 09B9-e0c5b8bbd566112fe1966cf6aed0a09f.json
Checklist
pre-commitchecks pass / the code has been formatted using Black