Migration to Quirks v2 #4619
Open
Migration to Quirks v2 #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devices: MLI - ZBT-Remote-ALL-RGBW - tint-Remote-white (added) - implemented device automation triggers from @SimpleUserHA (SimpleUserHA@4e85a04) - fixes zigpy#4298
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4619 +/- ##
==========================================
+ Coverage 92.28% 92.29% +0.01%
==========================================
Files 371 371
Lines 12158 12154 -4
==========================================
- Hits 11220 11218 -2
+ Misses 938 936 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
reviewed
Jan 4, 2026
| } | ||
|
|
||
| ( | ||
| QuirkBuilder("MLI", "ZBT-Remote-ALL-RGBW") |
Contributor
There was a problem hiding this comment.
Quirks can match multiple devices with .applies_to
Author
There was a problem hiding this comment.
Thank you for the suggestion, but I thought keeping the devices apart might be a good idea since the signatures are not exactly the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrates 'MLI ZBT-Remote-ALL-RGBW' to Quirks v2 and adds quirk for very similar 'MLI tint-Remote-white'
Additional information
Fixes #4298
implemented device automation triggers from @SimpleUserHA (SimpleUserHA@4e85a04)
Device diagnostics
zha-65b0bd4fb9032284773ce41e2eb4988b-MLI ZBT-ExtendedColor-b2f69fe517daa41d33f24c597985c03d.json
zha-65b0bd4fb9032284773ce41e2eb4988b-MLI tint-Remote-white-e56878a1f4dc08b174a959879490054a(1).json
Checklist
pre-commitchecks pass / the code has been formatted using Black