Add guards to prevent shutdown from failing #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #542 +/- ##
==========================================
+ Coverage 96.91% 96.94% +0.03%
==========================================
Files 63 63
Lines 10498 10518 +20
==========================================
+ Hits 10174 10197 +23
+ Misses 324 321 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
added a commit
to puddly/zha
that referenced
this pull request
Oct 24, 2025
* Add guards to prevent shutdown from failing * Add unit tests
puddly
added a commit
to puddly/zha
that referenced
this pull request
Oct 24, 2025
* Add guards to prevent shutdown from failing * Add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings will be logged if any callbacks or functions throw an error during disconnect. We ideally should not have any, every instance should be treated like a bug.
Similar PRs will be made to Core and Zigpy.