return all referenced types for typeDefinition #2246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdBronch
commented
Apr 11, 2025
| @@ -5600,6 +5600,13 @@ fn addReferencedTypes( | |||
| }, | |||
|
|
|||
| .ip_index, .compile_error => {}, | |||
| .either => {}, // TODO | |||
| .either => |either| { | |||
There was a problem hiding this comment.
this feels too easy to work...
xdBronch
commented
Apr 11, 2025
| @@ -107,8 +107,8 @@ test "struct init" { | |||
|
|
|||
| test "decl literal on generic type" { | |||
| try testDefinition( | |||
| \\fn Box(comptime T: type) type { | |||
| \\ return <tdef>struct</tdef> { | |||
| \\fn <tdef>Box</tdef>(comptime T: type) type { | |||
There was a problem hiding this comment.
is this change desirable here?
xdBronch
commented
Apr 11, 2025
| try testDefinition( | ||
| \\const <tdef>A</tdef> = struct {}; | ||
| \\const <tdef>B</tdef> = struct {}; | ||
| \\fn fo<>o(_: A) B {} |
There was a problem hiding this comment.
this fails, need to update the tests to work with array_of_DefinitionLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this needs more (any) testing but just throwing it up for now, its quite possibly not too good! but i think the results can be pretty desirable.
closes #2052