remove workaround for number literal hover with Zed editor #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i noticed this a little while ago but decided not to pr because of the overflowing and the issue is still open on the zed repo so im curious how/when this happened.
afaict it overflows on everything for binary, just might not be as easily noticed for some. im not opposed to this i guess, id be lying if i said not being able to see the binary representation of int literals broke my workflow :p |
Bisecting Zed versions showed that it's been fixed somewhere between 0.177.11 and 0.178.5. This led me to zed-industries/zed#25954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zed now appears to be able to properly render markdown so there should be no need to keep the workaround that has been added in #2058. This workaround was also missing a newline after the back ticks at the start which causes the first row in the table to be missing. fixes #2289
The downside is that the render markdown version overflows on small numbers and behaves very weird when trying to select text from the table.
Tested with Zed 0.181.5 on Linux
@xdBronch In case you wish to comment on this.