resolve relative paths in dynamic configurations#2331
Merged
Techatrix merged 5 commits intoJun 22, 2025
Conversation
dotcarmen
force-pushed
the
resolve-configuration-relative-paths
branch
from
May 24, 2025 19:40
06aeaa7 to
a25ea3d
Compare
Techatrix
requested changes
May 29, 2025
Techatrix
left a comment
Techatrix
left a comment
Member
There was a problem hiding this comment.
If there is a single workspace folder, the scopeURI field should be set to it when requesting configuration items here.
Resolving relative paths should be done in the handleConfiguration function instead of updateConfiguration. That is the only place where we receive config options where relative paths would be allowed.
Member
|
In case you missed them, these comments have not been addressed yet. |
Contributor
Author
addressed now! |
Techatrix
requested changes
Jun 15, 2025
Techatrix
force-pushed
the
resolve-configuration-relative-paths
branch
from
June 18, 2025 05:12
7eda252 to
9589e78
Compare
Techatrix
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2329
this PR resolves relative paths in configurations when
.allowRelative = trueis passed toServer.updateConfiguration.as discussed in #2329 (comment), this behavior only works when there's exactly 1 workspace assigned to the current zls server.