Add logging for maxBytesPerTrigger debugging #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
reviewed
Sep 9, 2025
| ledgers.last.entries = stats.currentLedgerEntries | ||
| } | ||
|
|
||
| logDebug(s"maxBytesPerTrigger: $topicPartition found ${ledgers.size} ledgers " + |
There was a problem hiding this comment.
Lets just use info logs since we are going to build a custom image
There was a problem hiding this comment.
I would also suggest that you prefix these added logs with something like "!--" so they are easy to find and query for.
There was a problem hiding this comment.
Done! Also based on the stats provided by the customer, I added a lot more logging to cover all bases.
added 3 commits
September 9, 2025 23:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as:
This change added tests and can be verified as follows:
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docdoc