Skip to content

Fix: results sharing a task_label are dropped (show all, not just the first) #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muralikpbhat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: results sharing a task_label are dropped (show all, not just the first) #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions vectordb_bench/frontend/components/check_results/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,15 @@ def getshownResults(
# label_visibility="hidden",
default=default_selected_task_labels or resultSelectOptions,
)
# Select every TestResult whose label is chosen, not just the first: more
# than one TestResult can share a task_label (e.g. the same engine re-run
# under one label), and index() would return only the first, silently
# dropping the rest from every results page.
selected = set(selectedResultSelectedOptions)
selectedResult: list[CaseResult] = []
for option in selectedResultSelectedOptions:
case_results = results[resultSelectOptions.index(option)].results
selectedResult += [r for r in case_results if case_results_filter(r)]
for option, result in zip(resultSelectOptions, results):
if option in selected:
selectedResult += [r for r in result.results if case_results_filter(r)]

return selectedResult

Expand Down