[WIP] ci: add Codecov bot for coverage reporting#1492
Open
jamesgao-jpg wants to merge 9 commits intozilliztech:mainfrom
Open
[WIP] ci: add Codecov bot for coverage reporting#1492jamesgao-jpg wants to merge 9 commits intozilliztech:mainfrom
jamesgao-jpg wants to merge 9 commits intozilliztech:mainfrom
Conversation
- Add test_helpers.h: IndexTestHelper template class for reducing repetitive Build/Search code - Add test_config_generators.h: Centralized ConfigGenerator class for all index configurations - Add test_flat.cc: Dedicated Flat index tests (build, search, bitset, range search, serialization) - Add test_distance_unit.cc: Unit tests for distance computation (L2, IP, L1, Linf) - Add test_distance_datatypes.cc: Multi-datatype distance tests (fp16, bf16, int8) - Add test_utility_components.cc: BlockingQueue and BitsetView unit tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
- Merge test_distance_unit.cc into test_distances.cc - Merge test_distance_datatypes.cc into test_simd.cc - Add sparse_utils unit tests (SparseRow, MaxMinHeap, GrowableVectorView, DocIdFilterByVector) - Add HNSW edge case tests (empty graph, heavy filtering, iterator) - Enable coverage reporting in CI workflow (with_coverage=True) - Add codecov.yml configuration (70% global, 80% patch targets) - Add scripts/run_incremental_coverage.sh for local coverage analysis Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
Coverage report generation is handled inline in ut.yaml workflow. The run_codecov.sh script redundantly re-runs tests and is not referenced by any CI pipeline. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jamesgao-jpg
changed the title
|
@jamesgao-jpg 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
…ces.cc Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
jamesgao-jpg
force-pushed
the
ci/codecov-integration
branch
from
dabc1c0 to
276e497
Compare
3 tasks
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (32.17%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=========================================
+ Coverage 0 32.17% +32.17%
=========================================
Files 0 421 +421
Lines 0 52466 +52466
Branches 0 12720 +12720
=========================================
+ Hits 0 16883 +16883
- Misses 0 33153 +33153
- Partials 0 2430 +2430 🚀 New features to boost your workflow:
|
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
- TC1: remove topk=120 (Heap/Reservoir handler is orthogonal to refine config)
- TC3: replace dim={31,511,1024} with {31,32} (511 same padding branch as 31, 1024->32 same no-pad branch)
- TC4: remove redundant UINT8+quant=false sub-cases for bf16/fp16 (build covered by quant=true, search covered by BF16/FP16+quant=false)
- TC5: remove scann_gen4 (UINT8+quant=false) from emb list config section (build subset of gen3, search covered by first section)
2. modify codecov.yml to include testing thirdparty libs
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
jamesgao-jpg
force-pushed
the
ci/codecov-integration
branch
from
b3d46d5 to
2aa8ca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codecov/codecov-action@v4upload step tout.yamlafter coverage report generation (tokenless, no secret needed for public repo)WITH_COVERAGEflag to Makefile for coverage-enabled buildsscripts/run_codecov.shand its Makefile target (it redundantly re-ran tests and was not used by any CI pipeline)Builds on PR #1450 which refactored UT and added coverage report generation, but kept pr separate for cleaness.
Test plan