nit: Hoist bf_query_dataset construction out of candidate-doc loop#1498
nit: Hoist bf_query_dataset construction out of candidate-doc loop#1498lyang24 wants to merge 1 commit intozilliztech:mainfrom
Conversation
…chEmbList Move query-tensor pointer calculation and GenDataSet() call from the inner per-candidate loop to the outer per-query-emb-list loop in stage 2. These values are invariant across candidate docs, so building them once per query emb-list avoids repeated small-object allocation overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: lyang24 <lanqingy93@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lyang24 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@lyang24 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
@foxspy were there any problems with our CI recently? |
|
/kind improvement |
3 participants
Move query-tensor pointer calculation and GenDataSet() call from the inner per-candidate loop to the outer per-query-emb-list loop in stage 2. These values are invariant across candidate docs, so building them once per query emb-list avoids repeated small-object allocation overhead.