Support Roaring-backed bitsets - #1732
Conversation
|
Welcome @hicder-rddt! It looks like this is your first PR to zilliztech/knowhere 🎉 |
c2d8ced to
71aa02b
Compare
|
@hicder-rddt 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
@hicder-rddt e2e jenkins job failed, comment |
71aa02b to
e458148
Compare
|
@hicder-rddt e2e jenkins job failed, comment |
|
@hicder-rddt Hi, is it good to review the PR? |
|
@alexanderguzhva thanks for looking. not yet, I'm still working on the corresponding change on Milvus side. That's why it's still in draft. Once it's up, I think it's better to review together. |
e458148 to
60b2ae1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hicder-rddt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add BitsetView support for dense, live Roaring, and frozen Roaring filters, including count updates, dense conversion, offsets, and out-id mapping. Preserve Roaring filters through search setup instead of rebuilding dense views, and add a typed Faiss fast path that expands Roaring filters into valid ID arrays for fp16, bf16, and int8 exhaustive distance paths. Wire roaring into Conan and CMake dependencies and cover live and frozen Roaring bitsets with unit tests. Signed-off-by: Hieu Pham <hieu.pham@reddit.com>
60b2ae1 to
709b998
Compare
Add BitsetView support for dense, live Roaring, and frozen Roaring filters, including count updates, dense conversion, offsets, and out-id mapping.
Preserve Roaring filters through search setup instead of rebuilding dense views, and add a typed Faiss fast path that expands Roaring filters into valid ID arrays for fp16, bf16, and int8 exhaustive distance paths.
Wire roaring into Conan and CMake dependencies and cover live and frozen Roaring bitsets with unit tests.
Part of the changes for milvus-io/milvus#51367