Skip to content

fix: keep current index version at 8 - #1776

Open
marcelo-cjl wants to merge 2 commits into
mainfrom
fix/restore-current-version-8
Open

fix: keep current index version at 8#1776
marcelo-cjl wants to merge 2 commits into
mainfrom
fix/restore-current-version-8

Conversation

@marcelo-cjl

@marcelo-cjl marcelo-cjl commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

What

Keep the default/current index version at 8 while leaving version 11 available as the maximum supported nullable id-map format.

Also update nullable emb-list tests so MUVERA/LEMUR scenarios explicitly use the emb-list meta v2 minimum version instead of inheriting the default current version.

Why

#1768 correctly introduced the nullable/version-gated format, but making it the default current version would publish that development format by default. Restoring current_version to 8 preserves existing default index behavior.

After restoring current_version, the nullable MUVERA/LEMUR emb-list UTs must opt into version 11 because their serialized metadata is intentionally rejected for versions below the emb-list meta v2 gate.

Related to #1687.

Validation

  • git diff --check
  • make BUILD_DIR=/home/ubuntu/skills/issue_review/workspaces/knowhere_pr_1776_main/build_ut_asan WITH_UT=True WITH_ASAN=True
  • build_ut_asan/Release/tests/ut/knowhere_tests "Nullable IVF_FLAT MUVERA/LEMUR emb-list APIs rebuild list ids after reload"
  • build_ut_asan/Release/tests/ut/knowhere_tests "Nullable native matrix covers every IndexNode operation"

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcelo-cjl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
@marcelo-cjl
marcelo-cjl force-pushed the fix/restore-current-version-8 branch from 8524774 to 77b0aaf Compare August 15, 2026 07:16
@mergify mergify Bot added dco-passed and removed needs-dco labels Aug 15, 2026
Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
@marcelo-cjl
marcelo-cjl force-pushed the fix/restore-current-version-8 branch from c8e6ab1 to eabb44e Compare August 15, 2026 09:49
@mergify mergify Bot added the ci-passed label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants