feat: Support physical join keys for backfill - #109
Open
congqixia wants to merge 6 commits into
Open
Conversation
Keep primary-key joins as the default while allowing callers to select a persisted scalar snapshot field through the API or --join-key. Resolve configured keys before source reads, normalize them to internal aliases, and validate exact types plus non-null uniqueness on both sides. Keep identity fields out of writer targets so result JSON and per-segment write behavior remain backward compatible. Document mapping and validation constraints and add regression coverage for configuration, resolution, source projection, and merge modes. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
liliu-z
reviewed
Aug 11, 2026
liliu-z
reviewed
Aug 11, 2026
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
liliu-z
reviewed
Aug 12, 2026
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep primary-key joins as the default while allowing callers to select a persisted scalar snapshot field through the API or --join-key.
Resolve configured keys before source reads, normalize them to internal aliases, and validate exact types plus non-null uniqueness on both sides. Keep identity fields out of writer targets so result JSON and per-segment write behavior remain backward compatible.
Document mapping and validation constraints and add regression coverage for configuration, resolution, source projection, and merge modes.