Coordination semaphores listing#1
Draft
zinal wants to merge 1 commit into
Draft
Conversation
Enhance ydb_coordination_v1.proto API by adding ListSemaphores RPC that allows users to list semaphores within a coordination node. Changes: - Add ListSemaphoresRequest, ListSemaphoresResponse, ListSemaphoresResult messages to ydb_coordination.proto - Add ListSemaphores RPC to ydb_coordination_v1.proto - Add TEvListSemaphores and TEvListSemaphoresResult to kesus.proto - Implement TTxSemaphoresList transaction in kesus tablet - Add RPC handler that resolves path via scheme cache and queries tablet - Register ListSemaphores in kesus gRPC service All changes follow YDB code style and standard approaches. Co-authored-by: Maksim Zinal <zinal@ydb.tech>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry
Added API and implementation to list semaphores within a coordination node.
Changelog category
Description for reviewers
This PR implements the
ListSemaphoresfunctionality for coordination nodes, allowing users to retrieve the names of semaphores.The implementation follows existing patterns within the YDB coordination service, specifically mirroring the approach used for
ListResourcesin rate limiters. This includes:ydb_coordination.protoandydb_coordination_v1.protowithListSemaphoresRPC.TEvListSemaphores,TEvListSemaphoresResult).TTxSemaphoresList) to iterate and list semaphores.rpc_list_semaphores_coordination_node.cpp) that resolves the coordination node path via the scheme cache and communicates with the Kesus tablet via a pipe.