ListSemaphores streaming RPC and review fixes#15
Draft
zinal wants to merge 5 commits into
Draft
Conversation
Add include_semaphore_names on DescribeNodeRequest and semaphore_names on DescribeNodeResult, populated by querying the kesus tablet (extended TEvGetConfig) only when requested. C++ SDK exposes IncludeSemaphoreNames on TDescribeNodeSettings and GetSemaphoreNames() on TNodeDescription. Tests cover tablet GetConfig and end-to-end DescribeNode behavior. Co-authored-by: Maksim Zinal <zinal@ydb.tech>
Introduce CoordinationService.ListSemaphores streaming SemaphoreDescription with include_details controlling compact vs full fields. Validate SelectRow like DescribeSemaphore via resolve proxy + security object. Kesus tablet handles TEvListSemaphores; proxy forwards as a direct request. C++ client exposes ListSemaphores() with TListSemaphoresIterator. Reverts DescribeNode optional semaphore names and GetConfig semaphore listing. Co-authored-by: Maksim Zinal <zinal@ydb.tech>
cursor
Bot
changed the title
…tests Co-authored-by: Maksim Zinal <zinal@ydb.tech>
cursor
Bot
changed the title
Co-authored-by: Maksim Zinal <zinal@ydb.tech>
… Semaphore) Co-authored-by: Maksim Zinal <zinal@ydb.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
TestListSemaphoresFromTablet: acquiringLock1viaSendAcquireLockusesTEvAcquireSemaphore(seeut_helpers.cpp), which creates a semaphore row namedLock1, soListSemaphorescorrectly returned size 1 before Alpha/Beta. The test no longer sets up that lock; proxy/session attach were unnecessary becauseListSemaphoresFromTabletandCreateSemaphoreuse direct edge messages to the tablet.