Fix mvn build creating unresolved ${project.parent.basedir} directories#1245
Fix mvn build creating unresolved ${project.parent.basedir} directories#1245shriyanshihihi wants to merge 1 commit intozinggAI:mainfrom
Conversation
|
Hi , |
| <resources> | ||
| <resource> | ||
| <directory>${project.parent.basedir}/python/phases</directory> | ||
| <directory>${project.basedir}/../python/phases</directory> |
There was a problem hiding this comment.
sorry whats the issue with project.parent.basedir? wont it take you to the root project folder? the change you have proposed is based on relative paths from assembly, but the earlier one was going to the base folder of zingg and then navigating to python
|
Thanks for checking this and for the question. You’re right that |
Summary
Fixes Maven build issue where unresolved
${project.parent.basedir}caused incorrect directory creation.Changes
${project.parent.basedir}with a safer module-relative path.Testing
mvn clean install -DskipTestsFixes #767