Skip to content

Fix mvn build creating unresolved ${project.parent.basedir} directories#1245

Open
shriyanshihihi wants to merge 1 commit intozinggAI:mainfrom
shriyanshihihi:fix-mvn-wrong-folders
Open

Fix mvn build creating unresolved ${project.parent.basedir} directories#1245
shriyanshihihi wants to merge 1 commit intozinggAI:mainfrom
shriyanshihihi:fix-mvn-wrong-folders

Conversation

@shriyanshihihi
Copy link

Summary

Fixes Maven build issue where unresolved ${project.parent.basedir} caused incorrect directory creation.

Changes

  • Replaced usage of ${project.parent.basedir} with a safer module-relative path.

Testing

  • Ran mvn clean install -DskipTests
  • Verified no unresolved directories are created.

Fixes #767

@shriyanshihihi
Copy link
Author

Hi ,
I’ve fixed the unresolved ${project.parent.basedir} path issue and raised a PR.
Build was verified with tests skipped due to known Windows/Scala limitations.
Looking forward to your feedback. Thanks!

<resources>
<resource>
<directory>${project.parent.basedir}/python/phases</directory>
<directory>${project.basedir}/../python/phases</directory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry whats the issue with project.parent.basedir? wont it take you to the root project folder? the change you have proposed is based on relative paths from assembly, but the earlier one was going to the base folder of zingg and then navigating to python

@shriyanshihihi
Copy link
Author

Thanks for checking this and for the question.

You’re right that ${project.parent.basedir} is meant to point to the root project. The issue I faced is that in some build steps (especially during resource/assembly processing), this value was not always getting resolved correctly in my local build, and Maven ended up creating a directory literally named ${project.parent.basedir}, which is what the issue describes.
Using a path based on ${project.basedir} keeps the resolution local to the module and avoids this unresolved directory creation. That’s why I switched to a relative path here.
If you prefer keeping a root-based reference, I’m happy to update this to use a clearly defined root property from the parent POM instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mvn build creating wrong folders

2 participants