fix: CachingResolver falls back to stale addresses when refresh fails#3949
Open
fix: CachingResolver falls back to stale addresses when refresh fails#3949
Conversation
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The stale-while-revalidate logic in CachingResolver#resolve discarded previousAddresses when the refresh promise completed with a failure, propagating UnknownHostException instead of returning the cached addresses. Use orElseSucceed to fall back to the previous addresses when the refreshed resolution fails.
guizmaii
force-pushed
the
fix/dns-resolver-stale-while-revalidate
branch
from
0d1858c to
96dfc65
Compare
guizmaii
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CachingResolver#resolvehad a bug in its stale-while-revalidate logic: when a background DNS refresh failed, thepreviousAddresseswere discarded and theUnknownHostExceptionwas propagated to callers, even though valid cached addresses were available.orElseSucceed(previous)so that a failed refresh falls back to the last known good addressesTest plan
resolve returns previous addresses when refresh failspassesDnsResolverSpectests pass (5/5)