Skip to content

Conversation

@wb14123
Copy link
Contributor

@wb14123 wb14123 commented May 6, 2025

Problem

Doobie dependencies are outdated. The auto PR #3248 failed because of the implementation of Read in Doobie has been changed.

Solution

Upgrade Doobie versions. Fix the implementation of converting Extractor to Read since the classes in Doobie have been refactored in typelevel/doobie#2136 .

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

Upgrade Doobie versions. Fix the implementation of converting Extractor
to Read since the classes in Doobie have been refactored in
typelevel/doobie#2136 .
@wb14123
Copy link
Contributor Author

wb14123 commented May 6, 2025

Seems the website build check is always failing for other PRs? I tried to run the command in the task output but it actually downgraded some deps so I'm not sure

@wb14123
Copy link
Contributor Author

wb14123 commented May 23, 2025

@juliano maybe you can help take a look?

Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you @wb14123 :)

@juliano juliano merged commit 3f5a0b2 into zio:master May 23, 2025
12 of 13 checks passed
larshagencognite added a commit to cognitedata/zio-protoquill that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants