Restore mutable Seq ArrayEn(De)coders for scala 2.13+ #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Doc updated with database actions return values
mergeback
- Add sizeHint in array decoder for better builder performance - Update link to contribution guide in the README.md - Remove duplicate, obsolete test ArrayEncodingSpec (same as in quill-test-kit)
b-gyula
force-pushed
the
mutable-ArrayEncoders
branch
from
d04f8be to
214e1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala 2.13 changed the default
Seqtoimmutable.Seqcausingio.getquill.context.sql.encoding.ArrayEncodingto restrict the usable collection types to ones inherited fromimmutable.SeqProblem
Code using classes with mutable collections does not compile on scala version 2.13+
Solution
There is no reason to restrict the allowed collection types to descendants of
immutable.Seqas they were allowed prior scala 2.13Notes
In fact I would widen the type to
Iterablesince the existing logic without modification works withSets also. I can change the PR if you agree...sizeHint@ collection creation inarrayDecoderChecklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers