fix: implement Deterministic hashCode for DynamicValue#1042
Open
samuel-asleep wants to merge 2 commits intozio:mainfrom
Open
fix: implement Deterministic hashCode for DynamicValue#1042samuel-asleep wants to merge 2 commits intozio:mainfrom
samuel-asleep wants to merge 2 commits intozio:mainfrom
Conversation
Author
|
@987Nabil can you please review when you have a moment |
Author
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicValue.hashCodewas non-deterministic, breaking use as HashMap/HashSet keys and across JVM runs in two distinct ways.Root Causes
Primitive[A]: Case classhashCodeincludedstandardType.##, which callsSystem.identityHashCodeonStandardTypesingletons (plainimplicit objects, notcase objects) — unstable across JVM runs.Dictionary: Auto-generatedhashCodeusedChunk.hashCode(order-sensitive), but entries originate from iterating aMapwith non-deterministic order. Two logically-identical dictionaries could produce different hashes and failequalswithin the same run.Fixes
Primitive[A]: OverridehashCodeusingstandardType.tag.##(a stableString) combined withvalue.##viaMurmurHash3:Dictionary: Override bothhashCode(entries.toSet.hashCode()) andequals(entries.toSet == otherEntries.toSet) to be order-independent and mutually consistent:Tests
Four property-based tests added to
DynamicValueSpec:PrimitivehashCode stability across separate instancesPrimitivehashCode stability viatoDynamicround-tripsDictionaryhashCode and equality are order-independentDynamicValuesfixes #655
/claim #655