fix(api): ADR 030 contract hardening for #585 - #586
Draft
livio-a wants to merge 3 commits into
Draft
Conversation
Centralize domain code→HTTP status mapping, unify error details marshalling, add structured req.invalid field details on flow Fields decode, clean up string WithDetails blobs, and document producer contract plus path/query sensitivity audit. Co-authored-by: Livio Spring <livio-a@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🦋 Changeset detectedLatest commit: b852192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Extract internal/isoduration with ISO JSON marshalling shared by ogen and SessionInvalidTTLDetails. Remove sessionInvalidTTLResponse special case; domain tests assert semantic Details without json.Marshal. Co-authored-by: Livio Spring <livio-a@users.noreply.github.com>
All resource-specific mappers only delegated to domainErrorResponse after the codeHTTPStatus manifest landed. Route every domain error through domainErrorResponse directly and remove dead flowdef aliases. Co-authored-by: Livio Spring <livio-a@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #585 contract hardening across three areas:
codeHTTPStatusmanifest ininternal/api/error_status.go; all domain errors route throughdomainErrorResponse.marshalErrorDetails; structuredRequestInvalidFieldDetailsfor flow field decode; string blobs moved toMessagewhere appropriate.x-sensitivecross-links.Follow-up cleanup in this PR:
internal/isoduration.Duration(ISO wire encoding at the type, not per-handler).*_errorResponsewrappers that only delegated todomainErrorResponse;errorResponsenow calls the manifest directly.Validation
go test ./internal/isoduration/ ./internal/api/ ./internal/domain/— passRelease notes / changeset
Changeset included (
.changeset/issue-585-contract-hardening.md) — API error envelope behavior change for consumers parsing details.Notes
WithDetails("project does not exist")intentionally deferred.details.detailsnesting preserved inmarshalErrorDetails.