Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: report team attachment in setup, status, and doctor #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: report team attachment in setup, status, and doctor #776
Changes from all commits
8f4df9b5a02136e9af02a5fcdfd809bca03933f086File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this one as-is, deliberately. Check messages in this battery quote the bare command:
schema.ts:37says "New projects scaffold editable defaults viazitadel setup". ThepublicCliCommandform belongs tonext_actions/next_commands, which is exactly where this check's advisory already puts it viaclaimAction(cliVersion)/claimCommand(cliVersion)(doctor/index.ts:263-266), so adoctorrun already prints the runnablenpx @zitadel/cli@<version> claimright below the warning.Inlining the versioned npx string into the check message too would duplicate it on every run and make the one-line warning considerably longer, without telling the reader anything the advisory does not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already handled:
advisoryForWarningsends withreturn { nextActions: unique(nextActions), nextCommands: unique(nextCommands) }(doctor/index.ts:279, helper at :490), so every branch including this one is de-duplicated before returning. That is also why the existingdocker-cliandmanaged-runtime-processesbranches push unconditionally. No change needed.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.