feat: Allow for reuse of cookie creation + decouple creation from http writer#848
Open
nickheyer wants to merge 1 commit intozitadel:mainfrom
Open
feat: Allow for reuse of cookie creation + decouple creation from http writer#848nickheyer wants to merge 1 commit intozitadel:mainfrom
nickheyer wants to merge 1 commit intozitadel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cookie handler used for .CheckCookie() and .SetCookie() is needlessly constrained and not reusable outside of the scope of an http resp writer. See #847
Definition of Ready