fix: made bearer token scheme case-insensitive for non-spec-compliant oidc providers#877
Open
wim07101993 wants to merge 4 commits into
Open
fix: made bearer token scheme case-insensitive for non-spec-compliant oidc providers#877wim07101993 wants to merge 4 commits into
wim07101993 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OP userinfo Authorization header parsing to accept a lowercase bearer scheme (case-insensitive), addressing interoperability with non-spec-compliant OIDC providers (closes #876).
Changes:
- Adjusted bearer-scheme detection in
getAccessTokento be case-insensitive. - Added a route test ensuring
/userinfosucceeds withauthorization: bearer <token>.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/op/userinfo.go | Updates Authorization header parsing logic for bearer scheme matching. |
| pkg/op/server_http_routes_test.go | Adds coverage for lowercase bearer Authorization scheme on userinfo route. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
When a client requested userinfo with a lowercase authorization header (
bearerinstead ofBearer), the server would reject it because it is not compliant to the spec.How the Problems Are Solved
Additional Changes
Additional Context