build: adopt Magefile for running acceptance tests #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliobischof
requested changes
Jun 24, 2025
Member
eliobischof
left a comment
eliobischof
left a comment
There was a problem hiding this comment.
In a go repo, Mage is definitely better than Make :-)
Let's update the CONTRIBUTING.md
Comment on lines
+76
to
+77
| fmt.Println("golangci-lint not found – falling back to `go vet`") | ||
| return sh.RunV("go", "vet", "./...") |
Member
There was a problem hiding this comment.
Let's try to have reproducible results by requiring a specific version of golangci-lint pinned in go.mod?
https://go.dev/doc/go1.24#tools
Comment on lines
+95
to
+98
| // Extra buffer so that flaky startup races are less likely. | ||
| if err := sh.RunV("sleep", "30"); err != nil { | ||
| fmt.Println("warning: sleep command failed:", err) | ||
| } |
Member
There was a problem hiding this comment.
Is there a condition we could retry quering until it is satisfied?
Updates SVG test fixtures to include XML declaration and namespace attributes required by Zitadel v4.7.0's API validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR swaps our bash-based test harness for a self-documenting Magefile. mage test:default now spins up the namespaced Docker-Compose stack, waits for health checks plus a 30-second buffer, runs the acceptance tests, streams compose logs automatically when debug flags are set, and then tears everything down. A test:cover variant produces profile.cov for Codecov. The change gives us a single, reproducible command that works identically on every developer machine and in CI while eliminating flaky start-up races and manual log collection.
Motivation and Context
It simplifies running the tests locally.
How Has This Been Tested?
By both running the tests locally and also by updating the workflows on GitHub.
Documentation:
None.
Checklist:
None.
Definition of Ready