Share Application in ZividCamera #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feuerste
force-pushed
the
flowstate
branch
2 times, most recently
from
ce2a9db to
fc1a257
Compare
feuerste
changed the title
feuerste
changed the title
feuerste
force-pushed
the
flowstate
branch
3 times, most recently
from
e1d6227 to
b051715
Compare
johningve
previously approved these changes
Nov 20, 2025
Contributor
johningve
left a comment
johningve
left a comment
There was a problem hiding this comment.
Thank you for the PR! The change looks good to me.
Contributor
Author
|
Thanks @johningve for your review! I addressed your comment and fixed the formatting, so it should be ready now. |
johningve
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to construct a
ZividCamerawith an already existingApplicationand a custom node name/namespace.This is helpful for having additional ROS helper nodes around
ZividCamera, which also require anApplicationthat can only be instantiated once.