Skip to content

Conversation

@Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented May 12, 2025

Description

Related Issue(s)

Other information

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.

@Ben-PH Ben-PH requested a review from vplasencia as a code owner May 12, 2025 07:34
@Ben-PH
Copy link
Contributor Author

Ben-PH commented May 12, 2025

Just a minor documentation addition that shows an empty batch insert will error.

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! 🚀

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ben-PH! Could you run make fmt to fix the formatting before we merge?

@Ben-PH
Copy link
Contributor Author

Ben-PH commented Jun 10, 2025

I added cmake and got a dprint error. I added dprint then got this error:

[dprint-plugin-exec]
Could not start dynamically linked executable: /home/ben/.cache/dprint/cache/plugins/dprint-plugin-exec/0.4.4/x86_64/dprint-plugin-exec
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
[dprint-plugin-prettier]
Could not start dynamically linked executable: /home/ben/.cache/dprint/cache/plugins/dprint-plugin-prettier/0.40.0/x86_64/dprint-plugin-prettier
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
[dprint-plugin-exec]
Could not start dynamically linked executable: /home/ben/.cache/dprint/cache/plugins/dprint-plugin-exec/0.4.4/x86_64/dprint-plugin-exec
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
[dprint-plugin-prettier]
Could not start dynamically linked executable: /home/ben/.cache/dprint/cache/plugins/dprint-plugin-prettier/0.40.0/x86_64/dprint-plugin-prettier
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
Error resolving plugin https://plugins.dprint.dev/exec-0.4.4.json: Failed plugin schema verification. This may indicate you are using an old version of the dprint CLI or plugin and should upgrade: Could not read success response.: failed to fill whole buffer
make: *** [Makefile:38: fmt] Error 12

I'm happy for this issue to be closed without merging. It's a trivial thing on its own, and there's a lot of other warnings missing IIRC.

@vplasencia vplasencia mentioned this pull request Jun 10, 2025
@vplasencia
Copy link
Member

Hey I just created an issue to fix this error: #80

@vplasencia vplasencia merged commit 7bf3a5d into zk-kit:main Jun 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants