-
Notifications
You must be signed in to change notification settings - Fork 13
doc: Document batch insertion error #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just a minor documentation addition that shows an empty batch insert will error. |
vplasencia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR! 🚀
vplasencia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Ben-PH! Could you run make fmt to fix the formatting before we merge?
|
I added cmake and got a dprint error. I added dprint then got this error: I'm happy for this issue to be closed without merging. It's a trivial thing on its own, and there's a lot of other warnings missing IIRC. |
|
Hey I just created an issue to fix this error: #80 |
Description
Related Issue(s)
Other information
Checklist
yarn stylewithout getting any errorsImportant
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.