use base64 to encode/decode raw_metadata#74
Open
ShuiRuTian wants to merge 2 commits into
Open
Conversation
Owner
|
Yes, this is a breaking change, and yes, you'll have to bump In general, I don't worry too much about migration because cacache is intended to be a cache, not persistent storage, so if you can't just throw everything away, you're probably using it wrong. |
Contributor
Author
|
Sounds good. I just fixed and bumped |
Owner
|
Yeah, I'll do that next time I do a semver-major release :) |
Contributor
Author
|
Hi @zkat, maybe we could release another major version? It's about 6 months since last release. |
Contributor
Author
|
@zkat ping~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use base64 to fix #72
However, this is a breaking change, we could not read the origin data any more.
Should we also bump INDEX_VERSION? And what about migration?
Maybe we could provide a deserializer, which could deserialize both 2 different data type (array and string) to Vec, but there is no way to reuse existing Vec visitor, I guess we have to copy and paste, kind of dirty.
Any other concerns or thoughts?