feat(highlighting): implement syntax highlighting for unnamed source codes #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both
name
andlanguage
are part of theSpanContents
abstraction, which comes from theNamedSource
struct. It would make more semantic sense if those were part of theSourceCode
abstraction instead. This would allow us to use syntax highlighting in unnamed source codes, which is not currently possible. This PR proposes this.Changes
NamedSource
toMietteSourceCode
, addinglanguage
to it.name()
andlanguage()
fromSpanContents
trait toSourceCode
trait.name
andlanguage
fromMietteSpanContents
struct toMietteSourceCode
struct.This is a breaking change because it refactors public APIs.
Before
After