Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ function pickManifest (packument, wanted, opts) {
new Date(opts.enjoyBy).toLocaleString()
}. Maybe try a different date?`
: ''
}\n` +
`Valid install targets:\n ${
Object.keys(distTags).concat(
!opts.includeDeprecated ? undeprecated : versions
).join(', ')
}`
)
err.code = 'ETARGET'
Expand Down
23 changes: 23 additions & 0 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,29 @@ test('errors if a non-registry spec is provided', t => {
t.done()
})

test('includes available versions in ETARGET message', t => {
const metadata = {
'dist-tags': {
foo: '1.0.1',
latest: '1.0.0'
},
versions: {
'1.0.0': { version: '1.0.0' },
'1.0.1': { version: '1.0.1' },
'1.0.2': { version: '1.0.2', deprecated: 'yes' }
}
}
t.throws(() => {
pickManifest(metadata, '^2.0.0')
}, /\s{2}foo, latest, 1.0.0, 1.0.1$/)
t.throws(() => {
pickManifest(metadata, '^2.0.0', {
includeDeprecated: true
})
}, /\s{2}foo, latest, 1.0.0, 1.0.1, 1.0.2$/)
t.done()
})

test('skips any invalid version keys', t => {
// Various third-party registries are prone to having trash as
// keys. npm simply skips them. Yay robustness.
Expand Down