fix: PolyCommit chunking and enforce domain bounds in commit()#1007
Open
radik878 wants to merge 1 commit intozkonduit:mainfrom
Open
fix: PolyCommit chunking and enforce domain bounds in commit()#1007radik878 wants to merge 1 commit intozkonduit:mainfrom
radik878 wants to merge 1 commit intozkonduit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ceil division to compute num_poly, avoid creating an extra empty polynomial when message.len() is a multiple of the usable domain size, return zero commitments for empty messages, and add bounds checks for num_unusable_rows relative to the evaluation domain. This aligns chunking behavior with the rest of the codebase and prevents silent underflow/miscommit scenarios.
Tests pass