Fix thermostat responsiveness and improve compatibility #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues causing the thermostat to be unresponsive and enhanced compatibility with other devices. Updated code formatting and improved debugging information for better error handling.
Fixed exception re-raising in set_thermostat_mode:
When catching a DaikinServiceException, the code now correctly passes the required status argument from the original exception when re-raising.
This resolves the TypeError: DaikinServiceException.init() missing 1 required positional argument: 'status'.
Improved error logging:
The error message now includes the full request body (as JSON) and the original exception details, making debugging easier.
No changes to API request logic or payload structure.
The request body and method for setting the thermostat mode remain unchanged.
These changes ensure that errors are properly propagated and logged, and that the custom exception is constructed with all required arguments.