Open
Conversation
commit 58c381424d96a23c31c34aecf0aca41d73f6b148 Merge: f7a9c9c 505440c Author: John Zhou <john-xyz@outlook.com> Date: Tue Mar 17 20:23:09 2026 -0500 Merge remote-tracking branch 'origin' into element-remove commit f7a9c9c Author: John Zhou <john-xyz@outlook.com> Date: Tue Mar 17 20:19:38 2026 -0500 Fixes commit 3c5a6e3 Author: John Zhou <john-xyz@outlook.com> Date: Tue Mar 17 18:06:23 2026 -0500 Element#remove polyfill
johnzhou721
force-pushed
the
element-remove
branch
from
f7a9c9c to
b1c419f
Compare
Contributor
Author
|
@zloirock Can you rerun Karma? It seems intermittent. |
Contributor
Author
|
@zloirock Take a look at this whenever you're ready -- sorry for the premature request for review. I've been holding off on implementing the same method for DocumentType etc. because I don't have so much time to create files, so only the Element polyfill for now. |
zloirock
reviewed
Mar 19, 2026
zloirock
reviewed
Mar 19, 2026
zloirock
reviewed
Mar 19, 2026
Owner
zloirock
left a comment
zloirock
left a comment
There was a problem hiding this comment.
I'm not sure that this is a good idea to add it right now. Now core-js contains only ES and cross-platform features; DOM elements are not cross-platform. There are many things to consider. Will see.
Contributor
Author
|
@zloirock If yo consider this to be good for core-js, then please consider merging it. If not, feel free to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zloirock Please take a look when you have time — thanks.
There's some other things with ChildNode mixin that have methods like remove, however I think they should be in separate modules; I may submit a PR with these later
Refs #1456.
TODO:
this