Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC4034 domain comparison + NSEC Cover #15

Closed
wants to merge 3 commits into from

Conversation

developStorm
Copy link
Member

Unfortunately, the original PR to the upstream (miekg#1315) has remained unmerged since 2021. After discussing with @phillip-stephens, we've decided to proceed by merging it into our own version instead.

@phillip-stephens
Copy link

@developStorm Coming back to this, know we've already merged DNSSEC support into ZDNS, would we need to make additional changes to ZDNS to take advantage of the better processing NSEC records? Seems to me this adds and exposes the Cover() function but we'd need to call into it in ZDNS to take advantage of this.

@developStorm
Copy link
Member Author

It doesn’t appear that we’ll require it for DNSSEC, so it’s fine to wait for it to be merged into upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants